[AutoDevNext] FFCLEANUP-71041 Resolve stale flag atlascode-rovodev-entitlement-notification - #1886
Open
atlassian[bot] wants to merge 1 commit into
Conversation
…ent-notification Remove the stale feature flag 'atlascode-rovodev-entitlement-notification' from the Features enum and refactor triggerEntitlementNotification() to remove its dependency on the flag check. The flag's final value was 'true', so notifications are now always enabled (subject to existing guards: jira.enabled, isBoysenberryMode, _enabled, and rovodev.enabled). This makes the previously flag-gated behaviour the permanent default without any change in user-facing behaviour. - Removed RovoDevEntitlementNotification from Features enum in features.ts - Removed Container.featureFlagClient.checkGate() call and showNotification guard from triggerEntitlementNotification() in rovoDevEntitlementChecker.ts - Removed unused 'Features' import from rovoDevEntitlementChecker.ts - Cleaned up unused mockFeatureGateClient in the corresponding test file - Added CHANGELOG entry Resolves: FFCLEANUP-71041
atlassian
Bot
requested review from
Blastoplex,
amarg-at,
bwieger-atlassian-com,
cabella-dot,
ccallcottstevens,
cindy-atl,
dchiew-atl,
jwang19-atlassian,
marcomura,
matt-lassian,
mattcolman,
sdzh-atlassian and
teg-atlassian
as code owners
June 29, 2026 08:52
|
Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. Already signed the CLA? To re-check, try refreshing the page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves stale feature flag
atlascode-rovodev-entitlement-notification(stale since 2025-12-26).The flag's final value was
true, meaning entitlement notifications should always be shown. This PR bakes that behaviour in permanently by removing the flag check.Changes
src/util/features.ts: RemovedRovoDevEntitlementNotification = 'atlascode-rovodev-entitlement-notification'from theFeaturesenum.src/util/rovo-dev-entitlement/rovoDevEntitlementChecker.ts: RemovedContainer.featureFlagClient.checkGate(Features.RovoDevEntitlementNotification)call and!showNotificationguard fromtriggerEntitlementNotification(). Removed unusedFeaturesimport.src/util/rovo-dev-entitlement/rovoDevEntitlementChecker.test.ts: Removed unusedmockFeatureGateClientmock andfeatureFlagClientContainer assignment.CHANGELOG.md: Added entry for this cleanup.Behaviour
No user-facing behaviour change — entitlement notifications were already always shown (flag was
true). The remaining guards (jira.enabled,isBoysenberryMode,_enabled,rovodev.enabled) are preserved.Recent PR change-site overlap
The clash check via TWG was inconclusive because this repository is hosted on GitHub, not Bitbucket. No manual overlaps were detected for the changed files (
src/util/features.ts,src/util/rovo-dev-entitlement/rovoDevEntitlementChecker.ts).Resolves: FFCLEANUP-71041
Rovo Dev code review: Rovo Dev couldn't review this pull request
Rovo Dev does not review pull requests created by bot accounts.