Skip to content

Enable PGO for macOS ARM64 Ruff releases #27572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
charliermarsh wants to merge 1 commit into from
+16 −3
Draft

Enable PGO for macOS ARM64 Ruff releases #27572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions .github/workflows/build-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ jobs:
macos-aarch64:
if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-build') }}
runs-on: ${{ github.repository == 'astral-sh/ruff' && 'namespace-profile-macos-15' || 'macos-15' }}
env:
# Use Rust's bundled Mach-O LLD, which supports ICF.
# ICF reduces the macOS aarch64 ruff binary size by ~0.8%.
RUSTFLAGS: "-C linker=rust-lld -C linker-flavor=ld64.lld -C link-arg=--icf=safe"
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
Expand All @@ -125,6 +129,14 @@ jobs:
with:
python-version: ${{ env.PYTHON_VERSION }}
architecture: arm64
- name: "Install LLVM profiling tools"
run: rustup component add llvm-tools-preview
- name: "Train PGO Ruff"
run: |
python scripts/build_ruff_pgo.py \
--target aarch64-apple-darwin \
--target-dir "${{ github.workspace }}/target/ruff-pgo" \
--train-only
- name: "Prep README.md"
run: python scripts/transform_readme.py --target pypi
- name: "Build wheels - aarch64"
Expand All @@ -134,9 +146,10 @@ jobs:
target: aarch64
args: --release --locked --out dist --compatibility pypi
env:
# Use Rust's bundled Mach-O LLD, which supports ICF.
# ICF reduces the macOS aarch64 ruff binary size by ~0.8%.
RUSTFLAGS: "-C linker=rust-lld -C linker-flavor=ld64.lld -C link-arg=--icf=safe"
RUSTFLAGS: "${{ env.RUSTFLAGS }} -Cprofile-use=${{ github.workspace }}/target/ruff-pgo/ruff.profdata"
# Apple Clang cannot consume profile data from rustc's LLVM version.
CFLAGS: "-fno-profile-generate -fno-profile-use"
CXXFLAGS: "-fno-profile-generate -fno-profile-use"
- name: "Test wheel - aarch64"
run: |
pip install dist/"${PACKAGE_NAME}"-*.whl --force-reinstall
Expand Down
Loading