Skip to content

Enable PGO for Linux x86-64 Ruff releases #27570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
charliermarsh wants to merge 5 commits into from
+543 −0
Draft

Enable PGO for Linux x86-64 Ruff releases #27570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
683dc07
Prototype profile-guided optimization for Ruff releases
charliermarsh Aug 7, 2026
f96ec0f
Train Ruff PGO on pinned ecosystem projects
charliermarsh Aug 7, 2026
a26e45c
Retry PGO corpus Git operations
charliermarsh Aug 7, 2026
a752a11
Harden Ruff PGO training script
charliermarsh Aug 7, 2026
912fdb3
Share the ty PGO training corpus
charliermarsh Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/build-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ on:
- pyproject.toml
# And when we change this workflow itself...
- .github/workflows/build-binaries.yml
- scripts/build_ruff_pgo.py

concurrency:
group: build-binaries-${{ github.ref }}
Expand Down Expand Up @@ -239,6 +240,18 @@ jobs:
with:
python-version: ${{ env.PYTHON_VERSION }}
architecture: x64
- name: "Install LLVM profiling tools"
if: ${{ matrix.target == 'x86_64-unknown-linux-gnu' }}
run: rustup component add llvm-tools-preview
- name: "Train PGO Ruff"
if: ${{ matrix.target == 'x86_64-unknown-linux-gnu' }}
run: |
python scripts/build_ruff_pgo.py \
--target "${{ matrix.target }}" \
--target-dir "${{ github.workspace }}/target/ruff-pgo" \
--train-only

echo "RUSTFLAGS=${RUSTFLAGS:+${RUSTFLAGS} }-Cprofile-use=${{ github.workspace }}/target/ruff-pgo/ruff.profdata" >> "$GITHUB_ENV"
Comment on lines +243 to +254

@chirizxc chirizxc Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, we can also add i686-pc-windows-msvc, x86_64-pc-windows-msvc, aarch64-apple-darwin, x86_64-apple-darwin, aarch64-unknown-linux-gnu, and i686-unknown-linux-gnu

@chirizxc chirizxc Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also build PGO build wheels for my library, and I don't think I've had any problems with these targets

Windows · macOS · manylinux

@charliermarsh charliermarsh Aug 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes they would all be covered. This is just experimental right now to gather data.

- name: "Prep README.md"
run: python scripts/transform_readme.py --target pypi
- name: "Build wheels"
Expand Down
Loading
Loading