Optimize development builds by default - #27562
Open
charliermarsh wants to merge 7 commits into
Open
Conversation
|
charliermarsh
force-pushed
the
charlie/ci-cargo-profile
branch
from
August 7, 2026 00:23
783a4c4 to
5ffbe99
Compare
charliermarsh
force-pushed
the
charlie/ci-cargo-profile
branch
from
August 7, 2026 12:35
3dc8d88 to
3cc40d9
Compare
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 96.96%. The percentage of expected errors that received a diagnostic held steady at 92.96%. The number of fully passing files held steady at 106/133. |
charliermarsh
changed the title
charliermarsh
marked this pull request as ready for review
August 7, 2026 15:12
MichaReiser
reviewed
Aug 7, 2026
Comment on lines
+22
to
+23
| CARGO_PROFILE_DEV_LTO: "false" | ||
| CARGO_PROFILE_DEV_OPT_LEVEL: 0 |
Member
There was a problem hiding this comment.
Hmm. How do we make sure we don't forget to add these to other new workflows? Should we have a CI profile? Is there a way that cargo can automatically pick up a profile based on the presence of an env variable?
Member
Author
There was a problem hiding this comment.
We could have a CI profile but we'd then have to thread it through to all jobs (there's no environment variable at present), and it turns out some jobs don't allow you to configure the profile (e.g., cargo publish --dry-run).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
opt-level = 1,debug = "line-tables-only", andlto = "off"the default development settings. This makes ordinary Cargo commands match our existing agent workflow, avoids local ThinLTO, and removes repeated profile overrides fromAGENTS.md.Preserve existing unoptimized CI behavior by explicitly setting
CARGO_PROFILE_DEV_OPT_LEVEL=0andCARGO_PROFILE_DEV_LTO=falsein the affected workflows, including documentation generation, playground validation, typeshed synchronization, typing conformance, and daily fuzzing. Existing CI commands, cache configuration, and cache producers remain unchanged. Release and profiling settings are unaffected.This follows the discussion in #27526 (comment).