Flag useless string expressions in preview - #27558
Draft
MichaReiser wants to merge 6 commits into
Draft
Conversation
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| useless-expression | 4357 | 4357 | 0 | 0 | 0 |
| unused-noqa | 1 | 0 | 1 | 0 | 0 |
This comment was marked as low quality.
This comment was marked as low quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
B018in preview mode.typestatements, and instance attribute assignments directly in a class-defined__init__.Closes #11292.
The open question from #11292 is whether this should be a separate rule so that projects using string literals as section separators can enable the remaining
B018checks:Test Plan
__init__instance attributes, annotated attributes, custom instance-parameter names, rebound receivers, locals, nested assignments, and other methods.cargo nextest run -p ruff_linter -p ruff_mdtest(2,837 passed)cargo clippy -p ruff_linter --all-targets --all-features -- -D warningscargo dev generate-all