[ty] Include inherited object members in protocol comparisons - #27548
Draft
AlexWaygood wants to merge 3 commits into
Draft
[ty] Include inherited object members in protocol comparisons#27548AlexWaygood wants to merge 3 commits into
AlexWaygood wants to merge 3 commits into
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 96.96%. The percentage of expected errors that received a diagnostic held steady at 92.96%. The number of fully passing files held steady at 106/133. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownprefect
sphinx
trio
flake8
|
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
unsound-return-statement |
0 | 0 | 1 |
| Total | 0 | 0 | 1 |
Large timing changes:
| Project | Old Time | New Time | Change |
|---|---|---|---|
colour |
0.57s | 1.25s | +121% |
DateType |
0.06s | 0.10s | +54% |
Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.
Raw diff:
meson (https://github.com/mesonbuild/meson)
- mesonbuild/compilers/mixins/visualstudio.py:392:16 warning[unsound-return-statement] Unsound return statement: `list[str] | list[str | Divergent]` is not a subtype of `list[str]`
+ mesonbuild/compilers/mixins/visualstudio.py:392:16 warning[unsound-return-statement] Unsound return statement: `list[str] | list[Divergent]` is not a subtype of `list[str]`
Merging this PR will degrade performance by 32.89%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | ty_micro[many_protocol_members_mismatch] |
579.8 ms | 1,030.9 ms | -43.76% |
| ❌ | Simulation | DateType |
235.5 ms | 405.4 ms | -41.9% |
| ❌ | Memory | DateType |
14.8 MB | 16 MB | -7.49% |
Tip
Investigate this regression with the CodSpeed MCP and your agent.
Comparing alex/protocol-object-fallback (ed3c4fa) with main (9a908ef)
Footnotes
-
84 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
AlexWaygood
force-pushed
the
alex/protocol-object-fallback
branch
3 times, most recently
from
August 6, 2026 15:16
4be5e68 to
af58f84
Compare
AlexWaygood
force-pushed
the
alex/protocol-object-fallback
branch
from
August 6, 2026 15:48
af58f84 to
844b2bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
objectmethods can satisfy compatible structural requirements.__hash__.