feat: handle srt tags - #146
Open
zoriya wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is very common to have ssa styles embedded in srt subtitles and astisub currently doesn't handle this and leaves tags as is in the output text.
There is no official spec for this but this is widely supported (ffmpeg, vlc, mpv to name a few players that support this). Every implementation follows aegisub's wiki (http://docs.aegisub.org/latest/ASS_Tags/).
See #31 for previous discussion on the subject.
This PR adds support for the most common tags and those that astisub already handled somewhere (positions, bold...). This leaves out tags that can't be processed easily (fonts, move, custom pos and so on). We could add support for those with follow up PRs if wanted but I'm not sure if there's as much value as with those really frequent tags (like position).