fix(storage): count OPENING quantity in asset total_quantity - #260
Merged
Conversation
The total_quantity subquery treated every non-BUY transaction as a reduction, so OPENING positions (used to import existing holdings) were subtracted and the sum went negative. map_asset_row filters non-positive quantities to None, hiding holdings on the assets page. Count only SELL as a reduction: BUY and OPENING both increase the position.
asiniscalchi
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Importing existing holdings uses OPENING transactions. The
total_quantitysubquery inassets.rscomputedSUM(CASE transaction_type WHEN 'BUY' THEN quantity ELSE -quantity END), so OPENING rows were subtracted, the sum went negative, andmap_asset_rowfiltered it toNone. The Assets page showed no owned quantity.Fix
Count only SELL as a reduction: BUY and OPENING both increase the position.
Tests
opening_transaction_counts_toward_asset_total_quantity(RED before fix, GREEN after)