Repository navigation
Conversation
A publishable package cannot declare a path dependency under `dependencies:` — `dart analyze` reports `invalid_dependency` and exits non-zero, so the Analyze CI job is red on master (introduced by the post-release `to_path.sh` run in 58f07bc). Move the local override to `dependency_overrides:`, the same form zorphy_migrator already uses; `scripts/publish.sh` strips the block and pins the hosted version before publishing. `dart analyze` in zorphy/ is clean again.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Closing — superseded by #160While this base-green repair was in flight, #160 (zorphy 2.5.0) merged to Master's |
Why
dart analyze(theanalyzeCI job) is red onmaster. Commit58f07bc("chore: restore path dependencies after v2.4.6 release", a direct push) left
zorphy_annotationas a path dependency underdependencies::A publishable package cannot declare a path dependency there — the analyzer
emits
invalid_dependency("Publishable packages can't have 'path'dependencies") and
dart analyzeexits non-zero, failing the job. Every PRbranched from master inherits this red (e.g. #161).
Fix
Move the local path reference to
dependency_overrides:, exactly the formzorphy_migratoralready uses for the same sibling package:dependency_overridesis not part of the published package metadata, so theinvalid_dependencywarning is gone.scripts/publish.shalready handles thisform — it strips the
dependency_overridesblock and pins the hosted versionbefore
dart pub publish.Verification
dart pub get→zorphy_annotation 2.4.6 from path ../zorphy_annotation (overridden)— local dev still resolves to the sibling checkout.dart run build_runner buildinzorphy/example, thendart analyzeinzorphy/→ No issues found!This is a base-green repair only; it carries no behavior change.