Skip to content

fix: keep zorphy_annotation path dep out of dependencies (base-green repair) - #162

Closed
arrrrny wants to merge 1 commit into
masterfrom
fix/base-analyze-path-dep
Closed

arrrrny wants to merge 1 commit into
masterfrom
fix/base-analyze-path-dep

Conversation

@arrrrny

@arrrrny arrrrny commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Why

dart analyze (the analyze CI job) is red on master. Commit 58f07bc
("chore: restore path dependencies after v2.4.6 release", a direct push) left
zorphy_annotation as a path dependency under dependencies::

dependencies:
  zorphy_annotation:
    path: ../zorphy_annotation

A publishable package cannot declare a path dependency there — the analyzer
emits invalid_dependency ("Publishable packages can't have 'path'
dependencies") and dart analyze exits non-zero, failing the job. Every PR
branched from master inherits this red (e.g. #161).

Fix

Move the local path reference to dependency_overrides:, exactly the form
zorphy_migrator already uses for the same sibling package:

dependencies:
  zorphy_annotation: ^2.4.6
...
dependency_overrides:
  zorphy_annotation:
    path: ../zorphy_annotation

dependency_overrides is not part of the published package metadata, so the
invalid_dependency warning is gone. scripts/publish.sh already handles this
form — it strips the dependency_overrides block and pins the hosted version
before dart pub publish.

Verification

  • dart pub get → zorphy_annotation 2.4.6 from path ../zorphy_annotation (overridden) — local dev still resolves to the sibling checkout.
  • dart run build_runner build in zorphy/example, then dart analyze in zorphy/ → No issues found!

This is a base-green repair only; it carries no behavior change.

A publishable package cannot declare a path dependency under `dependencies:`
— `dart analyze` reports `invalid_dependency` and exits non-zero, so the
Analyze CI job is red on master (introduced by the post-release `to_path.sh`
run in 58f07bc). Move the local override to `dependency_overrides:`, the same
form zorphy_migrator already uses; `scripts/publish.sh` strips the block and
pins the hosted version before publishing. `dart analyze` in zorphy/ is clean
again.
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a139e38e-1483-4744-ac34-7b464a8976bc
Commits

Reviewing files that changed from the base of the PR and between 58f07bc and edf09fe.

Files selected for processing: 1

  • zorphy/pubspec.yaml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@arrrrny arrrrny added the bug Something isn't working label Nov 16, 2026
@arrrrny

arrrrny commented Nov 16, 2026

Copy link
Copy Markdown
Owner Author

Closing — superseded by #160

While this base-green repair was in flight, #160 (zorphy 2.5.0) merged to
master and fixed the same root cause durably: zorphy/pubspec.yaml now pins
the hosted zorphy_annotation: ^2.5.0, and local dev overrides live in a
committed zorphy/pubspec_overrides.yaml (written by the reworked
scripts/to_path.sh). That is the better mechanism — it leaves the published
constraint untouched instead of parking a dependency_overrides block in
pubspec.yaml.

Master's analyze job is green again, so this PR is no longer needed and its
pubspec.yaml edit would now conflict with #160. Closing.

@arrrrny arrrrny closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant