-
Notifications
You must be signed in to change notification settings - Fork 18
ci: Add kind e2e test #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EnricoMi
wants to merge
6
commits into
armadaproject:main
Choose a base branch
from
EnricoMi:ci-add-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bce86de
Add kind integration test
EnricoMi 4bbced9
Retry creating and getting queue, submitting job
EnricoMi 7c7abca
Rename integration to e2e
EnricoMi 561dced
Use armada-operator from sources in e2e workflow
EnricoMi c04d991
Move e2e test into scripts/e2e-test.sh
EnricoMi 6100746
Rework e2e-test.sh
EnricoMi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| name: End2End tests | ||
|
|
||
| on: | ||
| workflow_call: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| kind: | ||
| name: Kind | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Go | ||
| id: setup-go | ||
| uses: ./.github/actions/setup-go-cache | ||
| with: | ||
| cache-prefix: go-integration-kind | ||
|
|
||
| - name: Starting Armada cluster | ||
| run: make kind-all | ||
|
|
||
| - name: Create queue | ||
| run: | | ||
| # Create queue | ||
| for second in {1..60} | ||
| do | ||
| if ./bin/app/armadactl create queue example 2> armadactl-${second}.log | ||
| then | ||
| if [[ second -eq 1 ]] | ||
| then | ||
| echo "Successfully created queue 'example'" | ||
| else | ||
| echo "Successfully created queue 'example' after ${second}s" | ||
| echo "Previously failed due to:" | ||
| cat armadactl-$((second-1)).log | ||
| fi | ||
| exit | ||
| fi | ||
| sleep 1 | ||
| done | ||
|
|
||
| echo "Failed to create queue 'example' after ${second}s" | ||
| cat armadactl-${second}.log >&2 | ||
| exit 1 | ||
|
|
||
| - name: Test queue exists | ||
| run: | | ||
| # Test queue exists | ||
| for second in {1..60} | ||
| do | ||
| if ./bin/app/armadactl get queue example 2> armadactl-${second}.log | ||
| then | ||
| if [[ second -eq 1 ]] | ||
| then | ||
| echo "Successfully inspected queue 'example'" | ||
| else | ||
| echo "Successfully inspected queue 'example' after ${second}s" | ||
| echo "Previously failed due to:" | ||
| cat armadactl-$((second-1)).log | ||
| fi | ||
| exit | ||
| fi | ||
| sleep 1 | ||
| done | ||
|
|
||
| echo "Failed to inspected queue 'example' after ${second}s" | ||
| cat armadactl-${second}.log >&2 | ||
| exit 1 | ||
|
|
||
| - name: Submit job | ||
| run: | | ||
| # Submit job | ||
| for second in {1..60} | ||
| do | ||
| if ./bin/app/armadactl submit dev/quickstart/example-job.yaml 2> armadactl-${second}.log | ||
| then | ||
| if [[ attempt -eq 1 ]] | ||
| then | ||
| echo "Successfully submitted job" | ||
| else | ||
| echo "Successfully submitted job after ${second}s" | ||
| echo "Previously failed due to:" | ||
| cat armadactl-$((second-1)).log | ||
| fi | ||
| exit | ||
| fi | ||
| sleep 1 | ||
| done | ||
|
|
||
| echo "Failed to submitted job after ${second}s" | ||
| cat armadactl-${second}.log >&2 | ||
| exit 1 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make kind-allinstalls the latest released Armada Operator Helm chart - https://github.com/armadaproject/armada-operator/blob/main/Makefile#L214This way we run e2e tests for the latest released Operator, and in case of a change to Operator code or Helm chart, the e2e test won't cover that scenario.
I think it might be better to create a
make kind-all-localor edit themake kind-all-devto build the code and install from the local Helm chart.That way we would cover the scenario to do an e2e test on current Operator code and on current Helm chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this?
561dced#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R218