fix(build): keep the swipe divider crisp at any zoom - #2433
Merged
Conversation
Draw the divider in the pane's screen space instead of over the image: sizing it in image space meant dividing every length by the zoom, and layout quantizes those tiny lengths before scaling them back up, which thickened the bar and distorted the chevrons once zoomed in. Drop the handle disc for two chevrons flanking the bar, and let the wheel zoom the screenshot over them rather than the page. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The swipe divider was drawn in image space, so every length was divided by the zoom — and layout quantizes those tiny lengths before scaling them back up, which thickened the bar and distorted the chevrons once zoomed in. It now lives in the pane's screen space, where lengths are plain pixels and only the position goes through the transform. The handle disc is replaced by two chevrons flanking the bar, so nothing covers the pixels being compared. Zooming with the wheel over the divider now zooms the screenshot instead of the whole page: the class that marks an overlay as swallowing drags is split from the one that marks it as handling the wheel itself.
🤖 Generated with Claude Code