Replace nonexistent Appsignal.apply_request call - #380
Merged
Conversation
The `custom_error` action in the Rails 8 example apps called `Appsignal.apply_request(request)` inside the `send_error` block. That helper has never existed, so the block raised `NoMethodError` instead of attaching the request to the reported error. Use the real public helpers to attach the request context: set the action, and add the request's params and headers. Now `/custom_error` reports the error with its request context, as intended.
|
Hi @unflxw, We've found some issues with your Pull Request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
custom_erroraction in the Rails 8 example apps calledAppsignal.apply_request(request)inside thesend_errorblock. That helper has never existed, so the block raisedNoMethodErrorinstead of attaching the request to the reported error.Use the real public helpers to attach the request context: set the action, and add the request's params and headers. Now
/custom_errorreports the error with its request context, as intended.Found while investigating a collector-mode trace-context merge. The raising block also exposed a gap in the Ruby integration, fixed separately in appsignal/appsignal-ruby#1544 (a raising error block left the transaction unfinished). This PR only fixes the example app.