Extract trace context onto an empty context - #1542
Merged
Merged
Conversation
The `extract_rack_context` and `extract_job_context` helpers called `OpenTelemetry.propagation.extract` without a `context:` argument, so it defaulted to `Context.current`. The W3C extractor returns its base context unchanged when the carrier has no `traceparent`, so a request with no incoming trace context inherited whatever span happened to be attached to the fiber. In collector mode that let a span left over from an earlier request become the parent of a later request's root span, merging unrelated requests into a single trace. Extract onto `Context.empty` instead, so extraction reflects only the carrier. A real incoming `traceparent` still parents (web) or links (jobs) exactly as before.
|
Hi @unflxw, We've found some issues with your Pull Request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
extract_rack_contextandextract_job_contexthelpers calledOpenTelemetry.propagation.extractwithout acontext:argument, so it defaulted toContext.current. The W3C extractor returns its base context unchanged when the carrier has notraceparent, so a request with no incoming trace context inherited whatever span happened to be attached to the fiber.In collector mode, that let a span left over from an earlier request become the parent of a later request's root span, merging unrelated requests into a single trace. Extract onto
Context.emptyinstead, so extraction reflects only the carrier. A real incomingtraceparentstill parents (web) or links (jobs) exactly as before.See #1544 for more on why there were spans left over from an earlier request in the first place.
[skip changeset]