fix(playwright): update context.request.headers with actual playwright headers - #2209
Draft
RohithPariki wants to merge 1 commit into
Draft
fix(playwright): update context.request.headers with actual playwright headers#2209RohithPariki wants to merge 1 commit into
RohithPariki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Request headers when using fingerprint generator or header generator are not saved in context.request.headers.
Root Cause
When browserforge injects headers, they bypass the Crawlee-level request headers list. Because the framework does not sync back the actual headers used by Playwright for the navigation, the context remains unaware of them.
Solution
Updated _playwright_crawler.py to retrieve the actual headers from Playwright's response.request and update the Crawlee context.request.headers after navigation.
Testing
Manual verification / static analysis. (Verified that actual Playwright headers are parsed into HttpHeaders).
Risk
Low risk. Modifies the state of context.request.headers after navigation, which ensures consistency with what was actually sent over the wire.
Issue
Closes #1055