Skip to content

[fix][test] Preserve class loading in broker interceptor fixtures #26567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merlimat merged 1 commit into from
Sep 13, 2026
+12 −2
Merged

[fix][test] Preserve class loading in broker interceptor fixtures #26567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pulsar-broker/src/test/java/org/apache/pulsar/broker/intercept/BrokerInterceptorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,15 @@
*/
package org.apache.pulsar.broker.intercept;

import static org.mockito.AdditionalAnswers.delegatesTo;
import static org.mockito.ArgumentMatchers.same;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.testng.Assert.assertEquals;
import java.io.IOException;
import java.net.URL;
import java.net.URLClassLoader;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Map;
Expand Down Expand Up @@ -93,7 +96,9 @@ public void setup() throws Exception {
@Override
protected void customizeMainPulsarTestContextBuilder(PulsarTestContext.Builder pulsarTestContextBuilder) {
HashMap<String, BrokerInterceptorWithClassLoader> brokerInterceptorWithClassLoaderHashMap = new HashMap<>();
NarClassLoader narClassLoader = mock(NarClassLoader.class);
// The filter chain uses this context class loader for resource and service-provider lookup.
NarClassLoader narClassLoader = mock(NarClassLoader.class,
delegatesTo(new URLClassLoader(new URL[0], getClass().getClassLoader())));
BrokerInterceptorWithClassLoader counterBrokerInterceptor =
new BrokerInterceptorWithClassLoader(new CounterBrokerInterceptor(), narClassLoader);
brokerInterceptorWithClassLoaderHashMap.put(CounterBrokerInterceptor.NAME, counterBrokerInterceptor);
Expand Down
7 changes: 6 additions & 1 deletion ...ker/src/test/java/org/apache/pulsar/broker/intercept/ExceptionsBrokerInterceptorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,13 @@
*/
package org.apache.pulsar.broker.intercept;

import static org.mockito.AdditionalAnswers.delegatesTo;
import static org.mockito.Mockito.mock;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertNotNull;
import static org.testng.Assert.assertTrue;
import java.net.URL;
import java.net.URLClassLoader;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.Map;
Expand Down Expand Up @@ -63,7 +66,9 @@ protected void cleanup() throws Exception {
protected void customizeMainPulsarTestContextBuilder(PulsarTestContext.Builder pulsarTestContextBuilder) {
Map<String, BrokerInterceptorWithClassLoader> listenerMap = new HashMap<>();
BrokerInterceptor interceptor = new ExceptionsBrokerInterceptor();
NarClassLoader narClassLoader = mock(NarClassLoader.class);
// The filter chain uses this context class loader for resource and service-provider lookup.
NarClassLoader narClassLoader = mock(NarClassLoader.class,
delegatesTo(new URLClassLoader(new URL[0], getClass().getClassLoader())));
listenerMap.put(interceptorName, new BrokerInterceptorWithClassLoader(interceptor, narClassLoader));
pulsarTestContextBuilder.brokerInterceptor(new BrokerInterceptors(listenerMap));
}
Expand Down
Loading