-
Notifications
You must be signed in to change notification settings - Fork 504
Remove the ADD_TRAILING_SLASH_TO_LOCATION feature flag #5273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iprithv
wants to merge
2
commits into
apache:main
Choose a base branch
from
iprithv:deprecate/add-trailing-slash-to-location
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 108 additions & 0 deletions
108
...java/org/apache/polaris/service/config/ProductionReadinessChecksAddTrailingSlashTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.polaris.service.config; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| import java.util.Map; | ||
| import org.apache.polaris.core.config.ProductionReadinessCheck; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.ExtendWith; | ||
| import org.mockito.junit.jupiter.MockitoExtension; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| class ProductionReadinessChecksAddTrailingSlashTest { | ||
|
|
||
| private static final String FLAG_KEY = "ADD_TRAILING_SLASH_TO_LOCATION"; | ||
|
|
||
| private ProductionReadinessChecks checks; | ||
|
|
||
| @BeforeEach | ||
| void setUp() { | ||
| checks = new ProductionReadinessChecks(); | ||
| } | ||
|
|
||
| @Test | ||
| void flagUnsetReturnsOk() { | ||
| FeaturesConfiguration config = mockConfig(Map.of(), Map.of()); | ||
|
|
||
| ProductionReadinessCheck result = checks.checkAddTrailingSlashToLocation(config); | ||
|
|
||
| assertThat(result.ready()).isTrue(); | ||
| } | ||
|
|
||
| @Test | ||
| void flagExplicitlyTrueReturnsOk() { | ||
| FeaturesConfiguration config = mockConfig(Map.of(FLAG_KEY, "true"), Map.of()); | ||
|
|
||
| ProductionReadinessCheck result = checks.checkAddTrailingSlashToLocation(config); | ||
|
|
||
| assertThat(result.ready()).isTrue(); | ||
| } | ||
|
|
||
| @Test | ||
| void flagExplicitlyFalseReturnsWarning() { | ||
| FeaturesConfiguration config = mockConfig(Map.of(FLAG_KEY, "false"), Map.of()); | ||
|
|
||
| ProductionReadinessCheck result = checks.checkAddTrailingSlashToLocation(config); | ||
|
|
||
| assertThat(result.ready()).isFalse(); | ||
| assertThat(result.getErrors()) | ||
| .singleElement() | ||
| .satisfies( | ||
| error -> { | ||
| assertThat(error.offendingProperty()).contains(FLAG_KEY); | ||
| assertThat(error.severe()).isFalse(); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| void realmOverrideFalseReturnsWarning() { | ||
| FeaturesConfiguration config = | ||
| mockConfig(Map.of(), Map.of("test-realm", mockRealmOverrides(Map.of(FLAG_KEY, "false")))); | ||
|
|
||
| ProductionReadinessCheck result = checks.checkAddTrailingSlashToLocation(config); | ||
|
|
||
| assertThat(result.ready()).isFalse(); | ||
| assertThat(result.getErrors()) | ||
| .singleElement() | ||
| .satisfies( | ||
| error -> { | ||
| assertThat(error.offendingProperty()).contains("test-realm").contains(FLAG_KEY); | ||
| assertThat(error.severe()).isFalse(); | ||
| }); | ||
| } | ||
|
|
||
| private static FeaturesConfiguration mockConfig( | ||
| Map<String, String> defaults, Map<String, RealmOverridable.RealmOverrides> realmOverrides) { | ||
| FeaturesConfiguration config = mock(FeaturesConfiguration.class); | ||
| when(config.defaults()).thenReturn(defaults); | ||
| when(config.realmOverrides()).thenReturn(realmOverrides); | ||
| return config; | ||
| } | ||
|
|
||
| private static RealmOverridable.RealmOverrides mockRealmOverrides(Map<String, String> overrides) { | ||
| RealmOverridable.RealmOverrides realmOverrides = mock(RealmOverridable.RealmOverrides.class); | ||
| when(realmOverrides.overrides()).thenReturn(overrides); | ||
| return realmOverrides; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.