fix(jdbc): skip slash-only prefixes in optimized overlap queries - #5029
Open
vigneshio wants to merge 2 commits into
Open
fix(jdbc): skip slash-only prefixes in optimized overlap queries#5029vigneshio wants to merge 2 commits into
vigneshio wants to merge 2 commits into
Conversation
5 tasks
vigneshio
force-pushed
the
fix/jdbc-overlap-odd-root-prefixes
branch
from
August 11, 2026 20:13
2c6a7b8 to
b513ba6
Compare
dimas-b
reviewed
Aug 14, 2026
dimas-b
left a comment
dimas-b
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall with minor comments 👍
dimas-b
reviewed
Aug 14, 2026
Scheme stripping turns s3://bucket/path into //bucket/path, so the prefix walk previously emitted / and // equality terms that are not real storage locations. Skip slash-only prefixes when building the overlap query. Same for file:/// paths that produced /// alone. Fixes apache#5023
vigneshio
force-pushed
the
fix/jdbc-overlap-odd-root-prefixes
branch
from
August 14, 2026 18:44
b513ba6 to
837b1dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5023.
Follow-up from the side note on #5003.
When building JDBC optimized location-overlap queries, scheme stripping turns paths like
s3://bucket/tmp/locationinto//bucket/tmp/location. The prefix walk then emitted slash-only terms (/,//) that are not real storage locations.