nimble/host: Fix handle validation in Read Mult Response - #2288
Open
piotrnarajowski wants to merge 1 commit into
Open
nimble/host: Fix handle validation in Read Mult Response#2288piotrnarajowski wants to merge 1 commit into
piotrnarajowski wants to merge 1 commit into
Conversation
piotrnarajowski
marked this pull request as draft
August 24, 2026 13:15
If one of the requested characteristic values filled the MTU, this caused the while loop to exit early. Remaining handle validation was skipped and as a result a response was issued even when the remaining handle was invalid. Validate all requaste handles first. Move MTU check outside while loop and truncate the response if needed after all handles were validated. Fixes qualification test case GATT/SR/GAR/BI-19-C
piotrnarajowski
force-pushed
the
read_mult_rsp_fix
branch
from
August 24, 2026 13:33
cd90035 to
d509d36
Compare
Contributor
Author
|
Update: freeing txom when exception occured was missing passes 20/20 times including iterations where PTS sends Read Mult Req with (LONG VAL HDL, INVALID HDL) 
|
piotrnarajowski
marked this pull request as ready for review
August 24, 2026 13:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one of the requested characteristic values filled the MTU, this caused the while loop to exit early. Remaining handle validation was skipped and as a result a response was issued even when the remaining handle was invalid.
Validate all requested handles first. Move MTU check outside while loop and truncate the response if needed after all handles were validated.
Fixes qualification test case GATT/SR/GAR/BI-19-C