Allow overriding MYNEWT_DOWNLOADER from command line - #556
Open
m-gorecki wants to merge 1 commit into
Open
Conversation
This adds new flag to load and run commands. The flag (--loader or short -L) allows to override the MYNEWT_DOWNLOADER value from syscfg. Usage example: --loader stm32_programmer_cli
Contributor
|
|
Contributor
Author
|
In case of loading, there is no use overriding other configs than MYNEWT_DOWNLOADER. I assumed it would be better to simply allow user to override only this specific syscfg value. Under the hood it uses the same code to override the value as |
Contributor
|
my main concern is that this simply overrides syscfg defined in some package - that doesn't sound like a maintainable solution. would be better if we "simply" add loader packages as a generic solution, i.e. add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds new flag to load and run commands.
The flag (--loader or short -L) allows to override the MYNEWT_DOWNLOADER value from syscfg. Usage example:
--loader stm32_programmer_cli