Skip to content

Recurse into subdirs when determining staleness - #1339

Open
pedro-w wants to merge 1 commit into
apache:masterfrom
pedro-w:issue-1324
Open

Recurse into subdirs when determining staleness#1339
pedro-w wants to merge 1 commit into
apache:masterfrom
pedro-w:issue-1324

Conversation

@pedro-w

@pedro-w pedro-w commented Jul 8, 2026

Copy link
Copy Markdown

When the plugin checks if the goal is up-to-date or needs to run, it generates a file containing the options and the names+timestamps of all files in the source and target directories. It then compares this to the last-saved version to
determine if anything had changed. The generation did not recursively descend into the directories and therefore files could change without the plugin noticing that it needed to run.

Also added some comments to explain the existing code.

I did not add unit tests as the changed source file does not have a corresponding unit test files. I have run and tested this on Windows only.

This relates to issue #1324


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioural changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

This is used to check if the goal is up-to-date or needs to run

Also added some comments to explain the existing code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant