fix: avoid misleading legacy warning for unknown rules - #1037
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the misleading deprecated-API warning emitted when an unknown Enforcer rule is configured. The warning is now emitted only after the legacy rule class has been loaded successfully.
Fixes #1023
Changes
Testing
mvn -pl maven-enforcer-plugin -am -Dtest=EnforcerRuleManagerTest -Dsurefire.failIfNoSpecifiedTests=false -Dspotless.apply.skip=true -Dspotless.check.skip=true test— PASS (10 tests)git diff --check— PASSThe repository's Spotless formatter is not compatible with the available JDK 27 runtime (
NoSuchFieldError); the focused test command therefore skipped Spotless only. Checkstyle and RAT completed successfully during the test build.AI assistance was used during investigation and implementation. The submitted changes were reviewed for correctness and are limited to this issue.