You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add back a constructor that was removed that Spring Boot uses.
Fix LoggerUpdaterTest that was broken after a different PR was applied. Claude performed the fixes:
Changed two tests in LoggerUpdateTest.java:
testUpdateLoggersPropertyListeners: it now keeps a reference to its configuration-started listener and removes it in a finally block.
propertyChangeListenerReceivesOldAndNewConfigurationOnReconfiguration: in a finally block, it now removes its property-change listener and calls context.reconfigure().
The LoggerUpdateTest change is needed: on main the leaked configuration-started listener fails propertyChangeListenerReceivesOldAndNewConfigurationOnReconfiguration, and with the finally blocks the class passes.
The restored LoggerConfig(String, Level, boolean) passes a null configuration to the protected constructor, which calls config.getLogEventFactory(), so Spring Boot's LevelSetLoggerConfig now gets a NullPointerException instead of NoSuchMethodError. Where should it get its LogEventFactory and ReliabilityStrategy without a configuration, and can a test build one, add it with addLogger and log through it?
The NPE is gone: a LoggerConfig from this constructor gets the context's configuration and logs after addLogger and updateLoggers.
Can LoggerUpdateTest get a test that does exactly that, with removeLogger in a finally? None of the current tests call this constructor, so a revert to null would stay green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
port-doneNo further port needed: all required ports are merged, or none was needed
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add back a constructor that was removed that Spring Boot uses.
Fix LoggerUpdaterTest that was broken after a different PR was applied. Claude performed the fixes:
Changed two tests in LoggerUpdateTest.java: