Skip to content

KAFKA-20891: Mark unused "streams" protocol configs internal - #23100

Merged
mjsax merged 1 commit into
apache:4.4from
suzhiking:remove-configs
Aug 12, 2026
Merged

KAFKA-20891: Mark unused "streams" protocol configs internal#23100
mjsax merged 1 commit into
apache:4.4from
suzhiking:remove-configs

Conversation

@suzhiking

@suzhiking suzhiking commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Warmup tasks are not yet supported with Kafka 4.40 release. This PRs marks the corresponding configs as "internal" to hide them from users. The two configs "num warmup task" and "acceptable recovery lag" are not used at all. The third, "task offset interval", is already live (it's sent to the client and the client would respect it); however, it's not very useful without actual warmup task support.

Reviewers: Matthias J. Sax matthias@confluent.io, Sean Quah
squah@confluent.io, Andrew Schofield aschofield@confluent.io

@github-actions github-actions Bot added tools group-coordinator triage PRs from the community small Small PRs labels Aug 6, 2026
@mjsax

mjsax commented Aug 6, 2026

Copy link
Copy Markdown
Member

Thanks for the PR -- did not review yet, but we should not target trunk but 4.4 branch (which was not cut yet).

So we cannot merge this PR just yet. Will review when I find time, but as it's blocked on 4.4 branch cut, there is no rush atm.

@suzhiking
suzhiking changed the base branch from trunk to 4.4 August 11, 2026 14:39
@mjsax mjsax added ci-approved and removed triage PRs from the community labels Aug 11, 2026
@mjsax
mjsax merged commit 0babc7f into apache:4.4 Aug 12, 2026
36 of 38 checks passed
@mjsax

mjsax commented Aug 12, 2026

Copy link
Copy Markdown
Member

Thanks for the PR. Merged to 4.4 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants