Skip to content

KAFKA-20889: reject empty group.instance.id values in Kafka Streams. #23099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chickenchickenlove wants to merge 1 commit into
base: trunk
Choose a base branch
from
+22 −1
Open

KAFKA-20889: reject empty group.instance.id values in Kafka Streams. #23099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1933,7 +1933,15 @@ public Map<String, Object> getMainConsumerConfigs(final String groupId, final St
// add group id, client id with stream client id prefix, and group instance id
consumerProps.put(ConsumerConfig.GROUP_ID_CONFIG, groupId);
consumerProps.put(CommonClientConfigs.CLIENT_ID_CONFIG, clientId);
final String groupInstanceId = (String) consumerProps.get(ConsumerConfig.GROUP_INSTANCE_ID_CONFIG);
final String groupInstanceId = (String) parseType(
ConsumerConfig.GROUP_INSTANCE_ID_CONFIG,
consumerProps.get(ConsumerConfig.GROUP_INSTANCE_ID_CONFIG),
Type.STRING
);
new ConfigDef.NonEmptyString().ensureValid(
ConsumerConfig.GROUP_INSTANCE_ID_CONFIG,
groupInstanceId
);
// Suffix each thread consumer with thread.id to enforce uniqueness of group.instance.id.
if (groupInstanceId != null) {
consumerProps.put(ConsumerConfig.GROUP_INSTANCE_ID_CONFIG, groupInstanceId + "-" + threadIdx);
Expand Down
13 changes: 13 additions & 0 deletions streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,19 @@ public void testGetGroupInstanceIdConfigs() {
assertNull(returnedProps.get(ConsumerConfig.GROUP_INSTANCE_ID_CONFIG));
}

@ParameterizedTest
@ValueSource(strings = {"", StreamsConfig.CONSUMER_PREFIX, StreamsConfig.MAIN_CONSUMER_PREFIX})
public void shouldRejectEmptyGroupInstanceId(final String prefix) {
props.put(prefix + ConsumerConfig.GROUP_INSTANCE_ID_CONFIG, "");
final StreamsConfig streamsConfig = new StreamsConfig(props);

final ConfigException exception = assertThrows(
ConfigException.class,
() -> streamsConfig.getMainConsumerConfigs(groupId, clientId, threadIdx)
);
assertTrue(exception.getMessage().contains(ConsumerConfig.GROUP_INSTANCE_ID_CONFIG));
}

@ParameterizedTest
@ValueSource(strings = {"", StreamsConfig.CONSUMER_PREFIX, StreamsConfig.MAIN_CONSUMER_PREFIX})
public void shouldAllowStaticMembershipWhenStreamsProtocolUsed(final String prefix) {
Expand Down