KAFKA-20898 PushTelemetry sets terminating flag on validation failure, permanently locking out client instance - #23094
Open
m1a2st wants to merge 1 commit into
Open
KAFKA-20898 PushTelemetry sets terminating flag on validation failure, permanently locking out client instance#23094m1a2st wants to merge 1 commit into
m1a2st wants to merge 1 commit into
Conversation
github-actions
Bot
added
triage
chia7712
reviewed
Aug 6, 2026
| clientInstance.terminating(request.data().terminating()); | ||
| } | ||
|
|
||
| // Update the client instance with the latest push request parameters only |
Member
There was a problem hiding this comment.
The reported edge case is specifically about the subscriptionId changing, so should we only skip setting the terminating flag for the ID check? I agree it's more consistent to include all validation checks, but I wanted to raise this for discussion
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in
ClientMetricsManager.processPushTelemetryRequest()wherethe
terminatingflag is unconditionally set in thefinallyblock,even when request validation fails.
When a client sends a
PushTelemetryrequest withterminating=truebut the request fails validation (e.g., stale
subscriptionId→UNKNOWN_SUBSCRIPTION_ID), the client instance is permanently markedas terminating. All subsequent requests from that client are rejected
with
INVALID_REQUEST, making recovery impossible without creating anew client instance.
Reviewers: Chia-Ping Tsai chia7712@gmail.com