KAFKA-20790: add AssignmentConfigs interface - #23092
Open
gabriellefu wants to merge 7 commits into
Open
Conversation
github-actions
Bot
added
triage
| /** | ||
| * Converts the raw assignment configs computed for the group into the typed configs passed to the assignor. | ||
| */ | ||
| private static AssignmentConfigs toAssignmentConfigs(Map<String, String> assignmentConfigs) { |
Contributor
There was a problem hiding this comment.
A better place for this method could be as a constructor or static method on AssignmentConfigsImpl.
| new GroupSpecImpl( | ||
| Map.of(), | ||
| new HashMap<>() | ||
| new AssignmentConfigsImpl(0, List.of()) |
Contributor
There was a problem hiding this comment.
It's going to be really annoying to update all these tests when we add new assignment configs.
We could consider declaring AssignmentConfigsImpl.DEFAULT or adding a constructor AssignmentConfigsImpl(Map<String, String>).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding AssignmentConfigs a public api for kip1357
Reviewers: Sean Quah squah@confluent.io