Skip to content

HIVE-29797: Use Iceberg 1.11.0 public variantShreddingFunc instead of reflection #6669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kokila-19 wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −26
Open

HIVE-29797: Use Iceberg 1.11.0 public variantShreddingFunc instead of reflection #6669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 1 addition & 26 deletions ...ceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/HiveFileWriterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import org.apache.iceberg.data.parquet.GenericParquetWriter;
import org.apache.iceberg.orc.ORC;
import org.apache.iceberg.parquet.Parquet;
import org.apache.iceberg.parquet.VariantShreddingFunction;
import org.apache.iceberg.parquet.VariantUtil;

class HiveFileWriterFactory extends BaseFileWriterFactory<Record> {
Expand Down Expand Up @@ -87,31 +86,7 @@ protected void configureDataWrite(Parquet.DataWriteBuilder builder) {
builder.createWriterFunc(GenericParquetWriter::create);
// Configure variant shredding if enabled and a sample record is available
if (VariantUtil.shouldUseVariantShredding(properties, dataSchema())) {
setVariantShreddingFunc(builder, VariantUtil.variantShreddingFunc(sampleRecord, dataSchema()));
}
}

/**
* Sets a {@link VariantShreddingFunction} on the underlying Parquet write builder.
*
* <p>{@link Parquet.DataWriteBuilder} does not expose {@code variantShreddingFunc} directly; it is set on an
* internal write builder held in the private {@code appenderBuilder} field. This method uses reflection to
* access that internal builder and invoke {@code variantShreddingFunc(VariantShreddingFunction)}.
*
* TODO: Replace with {@code DataWriteBuilder.variantShreddingFunc(VariantShreddingFunction)}
* once it becomes publicly available.
*/
private static void setVariantShreddingFunc(Parquet.DataWriteBuilder dataWriteBuilder,
VariantShreddingFunction fn) {
try {
java.lang.reflect.Field field = dataWriteBuilder.getClass().getDeclaredField("appenderBuilder");
field.setAccessible(true);
Object writeBuilder = field.get(dataWriteBuilder);
writeBuilder.getClass()
.getMethod("variantShreddingFunc", VariantShreddingFunction.class)
.invoke(writeBuilder, fn);
} catch (ReflectiveOperationException e) {
throw new RuntimeException(e);
builder.variantShreddingFunc(VariantUtil.variantShreddingFunc(sampleRecord, dataSchema()));
}
}

Expand Down
Loading