HIVE-29756: Beeline native installer added, native images compatibili… - #6652
HIVE-29756: Beeline native installer added, native images compatibili…#6652illiabarbashov-sketch wants to merge 18 commits into
Conversation
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
tests passed
labels
asf-ci-hive
added
tests failed
tests pending
tests unstable
tests passed
and removed
tests pending
tests failed
tests unstable
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
| bash --version | ||
|
|
||
| - name: Build Beeline installer | ||
| run: mvn package -pl beeline -am -DskipTests -P native-installer |
There was a problem hiding this comment.
Could we reuse the existing -Pdist profile here?
There was a problem hiding this comment.
Do you think we would need this? I mean, if we just rename native-isntaller to dist profile for beeline, wouldn't it triggered the jpackage native app on every nightly build? I thought it was something to avoid. Current hive building command, to what I know, is mvn install -Dtest=noMatches -Pdist -pl packaging -am Beeline currently doesn't have dist profile so it's just get built with the install command. If we change native-installer profile to dist the earlier hive build command will propagate the dist profile to beeline and jpackage will get activated. And we should be sure that Jenkins agent is able to run that. Also this will extend the time for nightly build.
| mvn package -pl beeline -am -DskipTests -P native-installer | ||
|
|
||
| Output (arch sub-directory so x64 and arm64 artifacts coexist): | ||
| beeline/target/installer/x64/beeline-4.3.0.dmg (Intel Mac) |
There was a problem hiding this comment.
maybe /target/apache-hive-beeline-X.Y.Z/x64/beeline-4.3.0.dmg ?
There was a problem hiding this comment.
updated
| krb5CacheFilePath = cacheDir.resolve("krb5cc_beeline_test"); | ||
|
|
||
| String userPrincipal = miniHiveKdc.getFullyQualifiedUserPrincipal(MiniHiveKdc.HIVE_TEST_USER_1); | ||
| BeelineResult kinitResult = runCommand(List.of("kinit", "-kt", |
There was a problem hiding this comment.
are we using kerberized setup here?
There was a problem hiding this comment.
Yes we're. We are using the keytab from MiniHiveKDC with the default config. However, this test will not be run on itself in our current Pipeline. It should be included into it if we want of course. I mean before running this test we would have to install the native app and run this test against that app. (Relatively easy on Linux, but a few extra steps anyway).
| return env; | ||
| } | ||
|
|
||
| private static final class BeelineResult { |
There was a problem hiding this comment.
could be refactored with record
|
4 participants
…ty tests added
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?