[#12343] improvement(core): add OCC for users and groups - #12351
Draft
yuqi1129 wants to merge 5 commits into
Draft
[#12343] improvement(core): add OCC for users and groups#12351yuqi1129 wants to merge 5 commits into
yuqi1129 wants to merge 5 commits into
Conversation
Code Coverage Report
Files
|
yuqi1129
force-pushed
the
feat/12343-occ-principals
branch
from
August 4, 2026 01:26
98f6ee5 to
d753898
Compare
yuqi1129
force-pushed
the
feat/12343-occ-principals
branch
from
August 4, 2026 08:54
d753898 to
fa645be
Compare
yuqi1129
force-pushed
the
feat/12343-occ-principals
branch
from
August 4, 2026 13:16
fa645be to
891153b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make managed user and group mutations concurrency-safe with database OCC and one transaction per service operation.
OptimisticLockExceptionwhen a CAS fails.This PR depends on #12350, which provides the metalake OCC fence.
Why are the changes needed?
Concurrent managed-principal operations must not create children under a concurrently deleted metalake, overwrite newer metadata, or commit only part of a multi-row service operation.
Fix: #12343
Does this PR introduce any user-facing change?
Concurrent managed user and group mutations fail atomically and report HTTP 409 through the shared optimistic-lock conflict contract.
How was this patch tested?
Added tests for parent fencing and rollback, metadata-only and by-id OCC updates, stale alter/delete conflicts, external-id updates, and relationship rollback. Ran:
./gradlew :core:test --tests 'org.apache.gravitino.storage.relational.service.TestUserMetaService' --tests 'org.apache.gravitino.storage.relational.service.TestGroupMetaService' -PskipITs