-
Notifications
You must be signed in to change notification settings - Fork 906
[#12342] improvement(core): add OCC for namespace hierarchy #12350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
472a791
c302751
51b3470
97e1fc8
31a90c8
11d7aa8
ca1b700
608fef5
adb7ee3
ae0451d
8fad8b8
f070d75
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -358,7 +358,9 @@ public boolean dropMetalake(NameIdentifier ident, boolean force) | |
| } | ||
|
|
||
| return store.delete(ident, EntityType.METALAKE, true); | ||
| } catch (NoSuchMetalakeException e) { | ||
| } catch (NoSuchMetalakeException | NoSuchEntityException e) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. First, Second, the entity cache in the store is already invalidated for us. Also, in this method the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is intentional, not a gap. There are two reasons. First, Second, the entity cache in the store is already invalidated for us. Also, in this method the |
||
| // Another server may have completed the drop after the initial existence check. | ||
| // Dropping an already-removed metalake remains an idempotent false result. | ||
| return false; | ||
|
|
||
| } catch (IOException e) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of changing this to
false?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interface is an explicit
createoperation, and we need to change it to false to avoid concurrent insertion of data into the database.