FINERACT-2455: Working Capital single active delinquency tag

[budaidev]

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
• If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
• I followed the AI Policy.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[galovics]

Review

Tag transition logic looks fine to me, and existing loans with several active tags on one period clean themselves up on the next classification, so I don't see the need for a data migration. Couple of questions though.

fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanDelinquencyReadPlatformServiceImpl.java (findDelinquencyStartDate / findPeriodDelinquencyStartDate):

I'm not convinced about walking the lifted tag chain to get the delinquency start date. The javadoc on applyDelinquencyTagForRange even says the read side relies on the lift date matching the add date exactly. That's a hidden contract across two services, and the next person who touches the write side (reset, disable/undo, reprocess, etc.) will break it without noticing. The range schedule period already knows when it became delinquent (toDate + delinquent days). Can't we get the start date from there, or store it on the period when the first tag is added? Thoughts?

fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanDelinquencyRangeScheduleServiceImpl.java:140:

Bugfix? Switching from transactionDate to the business date changes behaviour for backdated repayments, so it'd be good to mention it in the PR description. Also the comment at the end of allocateRepayment still says "applyRepayment classifies after the balance cap with the real transaction date". Pls update it.

Recommendation: COMMENT

[adamsaghy]

LGTM