FINERACT-2838: Transaction summary report - Exclude re-age and fix amortization mapping sign - #6463
Merged
Conversation
oleksii-novikov-onix
force-pushed
the
FINERACT-2838/transaction-summary-report-exclude-reage-fix-amortization-sign
branch
from
September 18, 2026 11:20
24b5416 to
a1ccba9
Compare
ruzeynalov
force-pushed
the
FINERACT-2838/transaction-summary-report-exclude-reage-fix-amortization-sign
branch
from
September 21, 2026 13:40
81d0476 to
e1d5533
Compare
…ortization mapping sign
…mary report - Exclude re-age and fix amortization mapping sign
oleksii-novikov-onix
force-pushed
the
FINERACT-2838/transaction-summary-report-exclude-reage-fix-amortization-sign
branch
2 times, most recently
from
September 22, 2026 10:36
0562f75 to
0e6f407
Compare
…fix to capitalized income and exclude re-amortize
oleksii-novikov-onix
force-pushed
the
FINERACT-2838/transaction-summary-report-exclude-reage-fix-amortization-sign
branch
from
September 22, 2026 14:24
0e6f407 to
2398541
Compare
adamsaghy
marked this pull request as ready for review
September 23, 2026 10:53
adamsaghy
deleted the
FINERACT-2838/transaction-summary-report-exclude-reage-fix-amortization-sign
branch
September 23, 2026 10:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FINERACT-2838: Transaction Summary Report and Transaction Summary Report with Asset Owner
Re-age / re-amortize exclusion
Re-age (29) and re-amortize (30) transactions are now excluded from both reports, the same way other non-reportable types are already skipped. Neither transaction moves money, so it should not produce report rows.
Amortization mapping sign fix (Transaction Summary Report with Asset Owner)
Amortization transactions are reported per base transaction using
m_loan_amortization_allocation_mapping. Each mapping row stores a positive amount typedAMorAM_ADJ. The amortization transaction amount is the net of these rows (sum ofAMminus sum ofAM_ADJ), and its type depends on the sign of the net. Until now every mapping row was reported as positive, so when one transaction netted both kinds of rows (for example, two backdated adjustments on different base transactions), the reported amounts did not add up to the transaction amount.The minority mapping type is now negated, so the reported rows add up to the transaction net:
AM_ADJrows are negatedAMrows are negatedThe fix is applied to both the posted and reversed amortization CTEs, for PostgreSQL and MySQL.
MySQL schema change
On MySQL,
stretchy_report.report_sqlis widened fromTEXTtoMEDIUMTEXT(changeset0254-0). The updated MySQL SQL for the Asset Owner report is about 66 KB, which is over the 65,535-byteTEXTlimit. The column is nullable and has no default, so no constraints are lost. PostgreSQL is not affected.Tests
New E2E scenarios in
Reporting.feature:AMandAM_ADJrows of two different buy down fees is reported with the correct signExisting scenarios were extended to cover re-age undo and buy down fee / capitalized income adjustments.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.