fix(clients): fix client list search for entity clients (#534) - #537
Aman-Mittal merged 2 commits into
Conversation
fb6e544 to
ad9533c
Compare
E2E — mocked backend🎭 E2E Tests✅ All green — 351 passed · 0 failed · 1 skipped, across 28 spec files in 6m 14s. By spec file
All 352 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 34477577819 from |
E2E — real Fineract🎭 E2E Tests✅ All green — 78 passed · 0 failed · 0 skipped, across 24 spec files in 7m 8s. By spec file
All 78 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 34477577819 from |
Aman-Mittal
left a comment
There was a problem hiding this comment.
LGTM and thanks for contribution
What and why :
The main Clients list was passing a hardcoded
legalFormvalue of1, which restricted the results to Person clients and excluded Entity clients.This change removes the hardcoded value so the main client list is no longer restricted to a specific legal form and can return both Person and Entity clients.
Closes #534
Unblocks #377
Verification :
src/app/features/clients/clients-list.component.test.tsto cover thegetClients()call without a hardcodedlegalForm.seedEntityClientine2e/utils/seed-api.tsand an E2E regression test ine2e/client.spec.tscovering Entity client visibility in the main/clientslist.node scripts/check-icons.mjsnode scripts/check-translations.mjsnode scripts/check-a11y-names.mjsnode scripts/check-route-permissions.mjsnode scripts/check-nav-ids.mjsnode scripts/check-api-surface.mjsnpx prettier --checkon touched filesnode --test "scripts/*.test.mjs"node --test "eslint-rules/*.test.js"Screenshots :
Not applicable — this is a non-visual fix to the client list query.
Checklist :
src/app/api/.src/app/core/adapters/instead of direct browser globals or imperative third-party APIs.