Skip to content

fix(.asf.yaml): discussions notification target + real check names in branch protection #3404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deacon-mp wants to merge 7 commits into
base: master
Choose a base branch
from
+2 −1
Open

fix(.asf.yaml): discussions notification target + real check names in branch protection #3404

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
58d1bdd
fix(.asf.yaml): add discussions notification target; use real check n…
Jul 24, 2026
2161021
Merge branch 'master' into fix/asf-yaml-discussions-and-protection
HackedRico Aug 27, 2026
4fdcf73
ci: require stable aggregate contexts instead of matrix job names
HackedRico Aug 27, 2026
d8de7d8
refactor: drop em dashes from .asf.yaml and CI workflow comments
HackedRico Aug 27, 2026
fa08398
Revert "refactor: drop em dashes from .asf.yaml and CI workflow comme…
HackedRico Aug 27, 2026
090465d
Revert "ci: require stable aggregate contexts instead of matrix job n…
HackedRico Aug 27, 2026
3785606
revert to master contexts
HackedRico Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .asf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,22 @@ github:
dependabot_alerts: true
dependabot_updates: false

# --- OPTIONAL self-serve branch protection (enable once the project agrees on required checks) ----
# --- Branch protection: 1 approving review + green CI required to merge to master -----------------
Comment thread
HackedRico marked this conversation as resolved.
protected_branches:
master:
required_pull_request_reviews:
Comment thread
HackedRico marked this conversation as resolved.
required_approving_review_count: 1
dismiss_stale_reviews: true
required_status_checks:
strict: true
# Contexts must be check-run (job) names as reported to GitHub, not workflow names.
contexts:
- Code Quality
- Security Checks
- "build (3.10.9, py310,style,coverage-ci)"
- "build (3.11, py311,style,coverage-ci)"
- "build (3.12, py312,style,coverage-ci)"
- "build (3.13, py313,style,coverage-ci)"
- "build (3.13, safety)"
- "build (3.13, bandit)"
required_conversation_resolution: true
# # required_signatures: true # only if all committers sign commits — can block merges otherwise
copilot_code_review:
Expand Down
Loading