Fix newline handling in inline HTML elements on import - #3231
Open
caddydove wants to merge 1 commit into
Open
Conversation
HTML used for pretty-printing (newlines inside <strong>, <a>, paragraph text, etc.) leaked into imported content as unwanted line breaks, turning '000\n111\n222' into separate blocks instead of '000 111 222'. Before converting HTML to markdown, collapse interior whitespace runs in text nodes to a single space (except in pre/textarea/script/style where whitespace is significant). Leading/trailing whitespace is preserved so newlines separating sibling inline elements still break them into distinct items (e.g. pasted '1. One\n2. Two' list-like spans). Fixes anyproto#3114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #3114.
When importing HTML, newlines used only to pretty-print the source (inside
<strong>,<a>, paragraph text, etc.) leaked into the imported content as unwanted line breaks — e.g.<strong>000\n111\n222</strong>became three separate blocks instead of one "000 111 222".Changes
pre/textarea/script/stylewhere it is significant.List with spans with new line itemsbehavior).Linktestdata expectation that was encoding the buggy behavior (interior newlines in paragraph text), and added regression tests for the reported cases.Test plan
go test ./core/block/import/markdown/anymark/ -count=1go test ./core/block/import/... -count=1go vet ./core/block/import/markdown/anymark/