Fix Notion inline equation import - #3227
Open
kentakom1213 wants to merge 2 commits into
Open
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Notion importer so that equations contained in rich text remain inline and preserve their original position.
Previously, inline equations were converted into standalone LaTeX blocks. This change serializes rich-text equations as
$expression$inside the surrounding text block.Standalone Notion equation blocks continue to be imported as standalone LaTeX blocks.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Not tested through the desktop UI.
The importer behavior is covered by unit tests.
Added tests?
Added tests covering:
The following test packages pass locally:
CGO_LDFLAGS=-Wl,-no_warn_duplicate_libraries go test -count=1 ./core/block/import/notion/api/blockCGO_LDFLAGS=-Wl,-no_warn_duplicate_libraries go test -count=1 ./core/block/import/notion/...Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
No post-deployment tasks are required.