fix: backdrop filter capture size never goes below 0

[antouhou]

Summary by CodeRabbit

• Bug Fixes
  • Fixed backdrop viewport overlap handling for fully offscreen capture regions.
  • Prevented invalid overlap values from affecting backdrop rendering.
• Tests
  • Added coverage verifying that fully offscreen regions produce no backdrop source and zero overlap.

[coderabbitai]

Warning

Review limit reached

@antouhou, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: aea6c5c7-12b3-4592-ac62-eb4bc9e2ca01

📥 Commits

Reviewing files that changed from the base of the PR and between b95650d and d56378b.

📒 Files selected for processing (1)

• src/shape.rs

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 32c41a5e-1b83-4385-a600-e161440c9a06

📥 Commits

Reviewing files that changed from the base of the PR and between 6343be4 and b95650d.

📒 Files selected for processing (1)

• src/renderer/passes.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The renderer now clamps negative viewport overlap dimensions before unsigned conversion. Tests cover capture regions beyond the right and bottom viewport edges.

Changes

Backdrop overlap handling

Layer / File(s)	Summary
Clamp and validate viewport overlap src/renderer/passes.rs	Viewport overlap dimensions are clamped to zero before conversion to u32. Tests verify that fully offscreen capture regions schedule no source copy and report zero overlap.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to b9565

This localized fix is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: preventing backdrop filter capture size calculations from becoming negative.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-nevagitve-filter-capture-size

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}