Porting of yhirose fix for #129 (also fix #248) - #263
Open
paolopas wants to merge 2 commits into
Open
Conversation
porting of original yhirose work, see ericcurtin/linenoise.cpp#9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This certainly fixes #248 better than my recent attempt at #255.
#255 suffered from the problem that any escape sequence would exit the completion loop, while the left and right arrow keys should accept the current completion.
So I ported the great solution already included in ericcurtin's fork, see ericcurtin/linenoise.cpp#9, adding the necessary changes to let the LEFT and RIGHT arrow keys (along with HOME, END, DELETE) accept the current completion.
@yhirose, I hope you don't mind.