Skip to content

Move terminal escape sequence handling into a function and reuse in c… - #230

Open
UplinkCoder wants to merge 1 commit into
antirez:masterfrom
UplinkCoder:completeion
Open

Move terminal escape sequence handling into a function and reuse in c…#230
UplinkCoder wants to merge 1 commit into
antirez:masterfrom
UplinkCoder:completeion

Conversation

@UplinkCoder

Copy link
Copy Markdown

…ompletion code

This allow escape sequences to work while within a completion cycle.
allowing prefix to work as expected.

@zlaazlaa

Copy link
Copy Markdown

Hi, I saw your modification on escape sequence handling. Is the handling work fine on your project? In my project, when I press 'Up' key, It sometimes (when I press 'Up' key fast) not go up, just print '[A' or 'A' or '[', which is the real code of 'Up' key.

case 'A': /* Up */

@UplinkCoder

Copy link
Copy Markdown
Author

Thanks for testing it @zlaazlaa I have not pressed the up key fast yet.
I will have a look now.

@UplinkCoder

Copy link
Copy Markdown
Author

@zlaazlaa I cannot reproduce it.
can you maybe do an asciicinema capture of it?

@zlaazlaa

Copy link
Copy Markdown

@zlaazlaa I cannot reproduce it. can you maybe do an asciicinema capture of it?

I did more test, I think it's the problem of the serial on my project. Thinks for your answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants