Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #406
Solution
Find named route tables in the demo VPC independent of the mutable owner tag,
then use the selected table's ID when updating its route and subnet association.
Prefer a table already associated with the demo subnet. If several candidates
exist without a uniquely associated table, stop for inspection rather than
choosing arbitrarily. Do not select the main route table or purge unrelated
subnet associations.
What changed
other subnet associations; a fresh VPC can still create its demo table.
and duplicate-table handling.
Validation
python3 -m unittest discover -s cloud/tests -p test_route_table_selection.py -v: 5 passed, covering a new table, an owner-tag change, selection among duplicates, ambiguous duplicates, and a matching main table. These tests exercise Ansible selection logic with fixture data; they do not call AWS.ansible-playbook -i localhost, cloud/create_vpc.yml --syntax-checkandansible-lint cloud/create_vpc.ymlpassed.The prior manual repair restored connectivity in the five workshops, but it did
not execute this proposed playbook change or establish the full cause of the
lost associations.