Repository navigation
Conversation
Document a path-aware GitHub ruleset approach so markdown-only changes can merge faster while playbooks and setup YAML stay behind normal review. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
good idea. we should investigate using a bot to auto-approve docs-only PRs, sort of like the RHDP team does with agnosticv. PRs that only have .md files and graphics (.png, .jpg, etc.) would be eligible. |
Add a pull_request_target workflow that approves markdown/graphics-only PRs via a GitHub App, and retarget the proposal/CONTRIBUTING docs to that approach instead of a path-aware ruleset alone. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Went with option B (auto-approve Action), per @jce-redhat's note. Shipped on this PR:
Still needs a one-time admin step: create/install the docs-approver App and set |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTRIBUTING.mdto match Chris's suggestion (.md+ images, RHDP-style bot).How it works
.github/workflows/docs-only-auto-approve.ymlonpull_request_target:*.md/*.png/*.jpg/*.jpeg/*.gif/*.webp/*.svg.gh pr review --approve, plus labeldocs-only.Admin follow-up (required for approvals to count)
apd-docs-approver(Pull requests: Read & write) onansible/product-demos.APD_DOCS_APPROVER_APP_IDandAPD_DOCS_APPROVER_APP_PRIVATE_KEY.Details:
.github/proposals/docs-only-pr-fast-path.md.Test plan
docs-onlylabel + bot APPROVE + mergeable with green CI.png) → auto-approve