feat(core): add embedded terminal runtime - #1338
Open
jlongster wants to merge 4 commits into
Open
Conversation
jlongster
marked this pull request as ready for review
August 5, 2026 19:04
jlongster
requested review from
Hona,
kommander,
msmps and
simonklee
as code owners
August 5, 2026 19:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #1317 pins Ghostty and makes its VT module available to OpenTUI, but OpenTUI still has no owned terminal state or mode-aware input boundary. The previous runtime PR (#1307) proved the behavior through a dynamic C loader; that implementation no longer matches the merged static Zig-module architecture.
This PR rebuilds only the internal runtime layer on the pinned Ghostty module. It deliberately excludes OpenTUI composition, native handles/FFI, TypeScript, and the public renderable so terminal ownership and input semantics can be reviewed independently.
Changes
Terminaland persistentTerminalStreamacross the complete runtime lifetime.Scope
This is the internal adapter/runtime layer. It does not add native handles, C/TypeScript FFI,
OptimizedBuffercomposition, cursor projection,EmbeddedTerminalRenderable, screen observation, benchmarks, or examples.The next stack layer will port the proven compositor and renderable behavior from closed PR #1308 onto this runtime.
Testing
bun run test:native(1873 passed, 6 skipped)bun run fmt:checkbun run lint