text-buffer: widen chunk width past u16 - #1304
Open
simonklee wants to merge 2 commits into
Open
Conversation
Lines longer than 65535 columns saturated chunk width at u16 max, so cursor, viewport, and rope weight drifted. Store width as u32 so horizontal extent stays accurate for very long lines.
Chunk width is already u32 after the widen. Remove bench clamps and narrow casts that still assumed u16, and keep a single long-line regression case past the old limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lines longer than 65535 columns saturated chunk width at u16
max, so cursor, viewport, and rope weight drifted. Store width
as u32 so horizontal extent stays accurate for very long lines.