fix(edit-buffer): extract ranges using configured width method - #1295
Open
simonklee wants to merge 1 commit into
Open
fix(edit-buffer): extract ranges using configured width method#1295simonklee wants to merge 1 commit into
simonklee wants to merge 1 commit into
Conversation
simonklee
changed the title
EditBuffer text and range APIs used fixed 1 MiB output buffers, silently truncating larger content. Size outputs from native text data and widen chunk widths so long lines remain readable. Honor configured width methods while preserving grapheme snapping, stop range traversal at the end offset, avoid redundant exact-size FFI copies, and widen rope balance math for large weights. Fixes #1287
simonklee
force-pushed
the
issue-1287/work
branch
from
July 28, 2026 09:59
eea140e to
a096340
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getTextRange always measured with Unicode rules, so wcwidth text
past 65535 columns and ranges starting inside a grapheme returned
the wrong bytes.
Honor the configured width method while preserving grapheme
snapping, stop traversal at the range end, avoid copying exact-sized
FFI output buffers, and widen rope balance math so large weights do
not wrap.
Fixes #1287