fix(core): longer scroll bar - #1237
Open
kouhe3 wants to merge 1 commit into
Open
Conversation
… render too short The Slider.viewPortSize setter clamped the value to max-min, which is correct for standalone sliders but breaks the ScrollBar use case where max-min = scrollSize - viewportSize. When viewportSize > scrollSize/2, the clamping truncated _viewPortSize, causing getVirtualThumbSize() to produce a thumb smaller than the expected viewportSize/scrollSize ratio. Add a debug demo in examples to visualize the diagnostic values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi I noticed that the scrollbar seems too short.
This PR added a new example to show scroll bar. and fixed length.
And this commit was made by AI.
by DeepSeek with Kilo Code CLI.