Add nologin decompiler regression fixture - #195
Open
zardus wants to merge 2 commits into
Open
Conversation
Member
Author
|
THIS MESSAGE WAS GENERATED BY AN AUTOMATED PROCESS Validation record for head
|
zardus
force-pushed
the
feature/syslog-varargs-recovery
branch
from
August 28, 2026 13:05
3f0142a to
7afaf47
Compare
Member
Author
|
THIS MESSAGE WAS GENERATED BY AN AUTOMATED PROCESS Exact fixture-shape and consumer-output record for #195.
Before — Exact consumer baselineAfter — Exact consumer head |
zardus
force-pushed
the
feature/syslog-varargs-recovery
branch
from
August 28, 2026 16:47
7afaf47 to
c5cc24b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS MESSAGE WAS GENERATED BY AN AUTOMATED PROCESS
Problem
The variadic-callsite regression needs the real
mainfunction from the x86-64nologinprogram to verify recovery of arguments passed tosyslog. The binaries baseline has no suitable fixture.Root cause
The reproducer lived only in public DecBench. A consumer test cannot fetch that dataset or build a substitute at run time, and a fabricated byte string would not exercise the compiler-produced callsite.
Fix
Add
tests/x86_64/decompiler/nologin, stripped with GNU Binutils, plus a README that pins the DecBench and upstream source revisions, both hashes, the transformation, and BSD 2-Clause terms.Testing
GNU Binutils 2.46
strip --strip-allreproduces the committed fixture byte-for-byte, and the focused consumer regression passes on it. The validation record contains the full consumer and workspace results plus content-identical rebase evidence.Validation: #195 (comment)
session: sharpen