Prevent preferences sidebar from collapsing - #1728
Conversation
b9222d0 to
4090bb1
Compare
|
LGTM. Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1728 +/- ##
==========================================
+ Coverage 59.18% 60.59% +1.41%
==========================================
Files 323 333 +10
Lines 37598 38911 +1313
Branches 4444 4579 +135
==========================================
+ Hits 22251 23578 +1327
+ Misses 14550 14459 -91
- Partials 797 874 +77 ☔ View full report in Codecov by Harness. |
|
Thanks for the fix! Any idea why this doesn't work on MacOS? |
|
I suspect that the extra few pixels are from theming. I'd suggest just changing the test to be |
|
Addressed in 872861f. The test now avoids comparing against a post-show |
Problem
The Preferences navigation pane uses the default collapsible behavior of
QSplitter. Dragging its divider fully left reduces the pane to zero width, making every preferences section inaccessible until the dialog is reopened.Reproduction
Expected behavior
The navigation pane should remain wide enough to display its entries while the settings pane continues to receive the remaining space.
Summary
Testing
QT_QPA_PLATFORM=offscreen python3 -m pytest -q tests/dialogs/test_preferences.pyruff check angrmanagement/ui/dialogs/preferences.py tests/dialogs/test_preferences.pyruff format --check angrmanagement/ui/dialogs/preferences.py tests/dialogs/test_preferences.pypython3 -m py_compile tests/dialogs/test_preferences.pygit diff --check