PoC of lowering compilation time using Python threading - #3
Open
p-wysocki wants to merge 11 commits into
Open
Conversation
alexsu52
reviewed
Sep 12, 2023
| current_group.operations, current_group.quantizers, quantized_model, quantized_model_graph | ||
| ) | ||
|
|
||
| modified_models.append(modified_model) |
Owner
There was a problem hiding this comment.
A general comment is that the proposed solution is not memory optimal. What I mean is that this solution requires storing as many copies of the model in memory as there are groups in groups_to_rank. For some models, the number of groups for ranking is in the hundreds. Probably, algorithm can be crashed by memory for huge models.
alexsu52
self-requested a review
September 21, 2023 05:59
alexsu52
pushed a commit
that referenced
this pull request
Apr 8, 2025
openvinotoolkit#3349) ### Changes This reverts commit 23803a3. ### Reason for changes openvinotoolkit#3343 introduced degradation in tests on Windows https://github.com/openvinotoolkit/nncf/actions/runs/13912395232
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
INFO:nncf:Calculating ranking score for groups of quantizershas been shortened from ~4 minutes to a little over 2 minutesRelated tickets
119274