fix(aws): make UnsupportedOperation a common error instead of a cloudwatch patch - #452
Open
Mkassabov wants to merge 2 commits into
Open
fix(aws): make UnsupportedOperation a common error instead of a cloudwatch patch#452Mkassabov wants to merge 2 commits into
Mkassabov wants to merge 2 commits into
Conversation
The patch added in e2f141d was not run through oxfmt, breaking the format:check step in CI on main.
Contributor
|
Install the packages built from this commit: Distilled@distilled.cloud/core bun add https://pkg.ing/@distilled.cloud/core/84881d2@distilled.cloud/aws bun add https://pkg.ing/@distilled.cloud/aws/84881d2 |
…watch patch Reverts the describeInsightRules-specific patch from #450 and adds UnsupportedOperation to COMMON_ERRORS/CommonAwsError, so it is typed and decodable on every operation. Local emulators reject unsupported APIs with this wire code regardless of service, so it belongs alongside UnknownOperationException rather than in per-service spec patches. Service-specific UnsupportedOperation schemas (ec2, cloudtrail, ...) still take decode precedence over the common one.
Mkassabov
force-pushed
the
fix/cloudwatch-patch-format
branch
from
August 14, 2026 14:57
11d126a to
335c6e8
Compare
Mkassabov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes the approach from #450: instead of patching
UnsupportedOperationonto cloudwatch'sdescribeInsightRulesviapatches/cloudwatch.json, add it toCOMMON_ERRORS/CommonAwsErrorinsrc/errors.tsso it is typed and decodable on every operation.Local emulators (floci/LocalStack) reject unsupported APIs with this wire code regardless of service, so it belongs alongside
UnknownOperationExceptionas a common error rather than in per-service spec patches.src/services/cloudwatch.tsregenerated back to its pre-patch stateDescribeInsightRulesError = InvalidNextToken | CommonErrorsstill includesUnsupportedOperation, so feat!: Effectful web frameworks alchemy#1206'scatchTag("UnsupportedOperation")keeps compilingUnsupportedOperationschemas (ec2, cloudtrail, ...) still take decode precedence over the common onepatches/cloudwatch.json(the fix(aws/cloudwatch): type UnsupportedOperation on describeInsightRules #450 patch was not run through oxfmt, breakingformat:checkon main)🤖 Generated with Claude Code