Skip to content

fix(ui): show a failed promotion step's own error message #6857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marvin9 wants to merge 2 commits into
base: main
Choose a base branch
from
+43 −19
Open

fix(ui): show a failed promotion step's own error message #6857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f044bc8
fix(ui): show a failed promotion step's own error message
Marvin9 Aug 21, 2026
9cc9c0c
fix(ui): always show an aborted Promotion's message
Marvin9 Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 43 additions & 19 deletions ui/src/features/stage/promotion-steps.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,31 @@ export const PromotionSteps = (props: PromotionStepsProps) => {

const phase = getPromotionStatusPhase(props.promotion);

const shouldShowMessage =
isPromotionPhaseTerminal(phase) &&
phase !== PromotionStatusPhase.SUCCEEDED &&
phase !== PromotionStatusPhase.ERRORED && // because its already handled at individual step level
!!props.promotion?.status?.message;
const message = props.promotion?.status?.message;

// A failed step's message becomes the Promotion's, so it is already on screen.
const hasIndividualPromotionStepTerminalMessage = (
props.promotion.status?.stepExecutionMetadata ?? []
).some((meta, i) => isFailedStep(i, props.promotion.status) && !!meta.message);

let shouldShowMessage = false;

if (isPromotionPhaseTerminal(phase)) {
switch (phase) {
case PromotionStatusPhase.FAILED:
case PromotionStatusPhase.ERRORED:
// The failing step already shows this message, so don't repeat it.
shouldShowMessage = !hasIndividualPromotionStepTerminalMessage;
break;
case PromotionStatusPhase.ABORTED:
// An abort is not attributable to any one step.
shouldShowMessage = true;
break;
}
}

const steps = props.promotion?.spec?.steps ?? [];

const errorItem = {
key: 'error',
label: <Alert message={props.promotion.status?.message} type='error' />,
showArrow: false,
collapsible: 'disabled' as const,
styles: { header: { paddingTop: 0 } }
};

// Steps with a registered extension are interactive
const hasExtension = (step: (typeof steps)[number]) =>
promotionStepExtensions.some((ext) => ext.identifier === step.uses);
Expand All @@ -76,9 +85,26 @@ export const PromotionSteps = (props: PromotionStepsProps) => {
key
};

return isFailedStep(i, props.promotion.status)
? [{ ...item, className: `${item.className || ''} !border-none` }, errorItem]
: [item];
if (!isFailedStep(i, props.promotion.status)) {
return [item];
}

const stepMessage = props.promotion.status?.stepExecutionMetadata?.[i]?.message;

if (!stepMessage) {
return [item];
}

return [
{ ...item, className: `${item.className || ''} !border-none` },
{
key: `${key}-error`,
label: <Alert message={stepMessage} type='error' />,
showArrow: false,
collapsible: 'disabled' as const,
styles: { header: { paddingTop: 0 } }
}
];
});

useEffect(() => {
Expand All @@ -97,9 +123,7 @@ export const PromotionSteps = (props: PromotionStepsProps) => {
activeKey={activeKeys}
onChange={(keys) => setActiveKeys(typeof keys === 'string' ? [keys] : keys)}
/>
{shouldShowMessage && (
<Alert message={props.promotion.status?.message} type='error' className='mt-4' />
)}
{shouldShowMessage && !!message && <Alert message={message} type='error' className='mt-4' />}
</>
);
};
Loading